audio: module-adapter: Fix SRC regression when ext_init dp_data present#10544
audio: module-adapter: Fix SRC regression when ext_init dp_data present#10544jsarha wants to merge 1 commit intothesofproject:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes an SRC DP initialization regression when dp_data is present in the ext_init payload by adjusting how the module adapter decides between legacy vs. extended init handling.
Changes:
- Changes the legacy/extended init decision to hinge on whether
module_datais present in theext_initpayload. - Adds a clarifying comment about assuming the legacy API when module data is absent.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Fix SRC DP regression when dp_data is present in the ext_init payload. The only situation where we can assume that there is no module specific init after the ext_init payload is when it was offered as part of ext_init payload. Completes fix abf1aa9 ("audio: module-adapter: fix SRC DP regression") Fixes: d263649 ("module: Add support for module-specific init data") Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>
jsarha
force-pushed
the
assume_legacy_mod_data_if_no_ext_init_mod_data
branch
from
1d0803c to
4841dc6
Compare
The problem is that with compressed support a new way to pass the module specific init was introduced, but for some reason Linux does not use the new method for SRC (probably its not used for anything but compressed?). So the only working condition to decide on the FW side which method to use (either part of ext init object array, or plain data after it) is to check if we have the data in the object array, and pass the remaining part of payload as a module specific init if we do not. |
2 participants
Fix SRC DP regression when dp_data is present in the ext_init payload.
The only situation where we can assume that there is no module specific init after the ext_init payload is when it was offered as part of ext_init payload.
Completes fix abf1aa9 ("audio: module-adapter: fix SRC DP regression")
Fixes: d263649 ("module: Add support for module-specific init data")
This fix is required for thesofproject/linux#5537 to work as it shoud.